search

click-contrib / click-log

Simple and beautiful logging for click applications
https://click-log.readthedocs.org/
MIT License
109 stars 24 forks source link

Breaking change in API #10

Open danielchatfield opened 7 years ago

danielchatfield commented 7 years ago

Hi, thanks for all your hard work on this.

This commit https://github.com/click-contrib/click-log/commit/e26170d8f40a4817a9178582d02248c1f082a32e introduced a breaking change to the API. Is there a way that I can change my code to:

untitaker commented 7 years ago

You can replace get_level with logging.getLogger(...).getLevel (same with set_level). This part is backwards compatible.

The rest less so, please take a look at https://github.com/pimutils/vdirsyncer/commit/6954b26e0fdb5035f6344b994fcc1afb726a6c04

You could detect the version of click-log and apply the correct decorators depending on that.

danielchatfield commented 7 years ago

@untitaker Thanks for the quick response.

I think I'll have to do detect the version and then either provide logger or not depending on the version.

untitaker commented 7 years ago

Just curious, isn't it an option for you to set a minimum requirement on the click-log version?

On Mon, Sep 04, 2017 at 12:52:55PM +0000, Daniel Chatfield wrote:

@untitaker Thanks for the quick response.

I think I'll have to do detect the version and then either provide logger or not depending on the version.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/click-contrib/click-log/issues/10#issuecomment-326956163

danielchatfield commented 7 years ago

@untitaker It's used in a bunch of internal tools that people usually update by just git pull so we try and avoid introducing new dependencies / changing required versions as much as possible.