click-contrib / click-repl

Subcommand REPL for click apps
MIT License
219 stars 40 forks source link

support for click 8 completion changes #76

Closed jm66 closed 3 years ago

jm66 commented 3 years ago

simple migration from _bashcomplete to shell_completion. Fixes #72.

andy-maier commented 3 years ago

I have tested this PR on one of our projects that use click-repl (https://github.com/zhmcclient/zhmccli/pull/173) and it installs fine with click 8.0 and also the auto-completion works fine.

jm66 commented 3 years ago

Hey @auvipy Any chance to accept this PR? Thanks

dvzrv commented 3 years ago

A merge and subsequent release of a new version would be much appreciated, as the upgrade to click has broken downstreams (such as Arch Linux: FS#71044).

untitaker commented 3 years ago

@auvipy the changes look fine, yes :)