search

click-contrib / click-repl

Subcommand REPL for click apps
MIT License
215 stars 41 forks source link

Can we get a new release to Pypi? #93

Closed andy-maier closed 1 year ago

andy-maier commented 1 year ago

Hello maintainers of this project. We'd like to use the recent updates for tab completion in some of our projects.

Could we please get a new release on Pypi (from the current master branch)?

auvipy commented 1 year ago

yes we should. @untitaker can you please take a look? or if you allow I might help

untitaker commented 1 year ago

what's your user? i can add you to pypi

On Mon, Mar 20, 2023, at 18:16, Asif Saif Uddin wrote:

yes we should. @untitaker https://github.com/untitaker can you please take a look? or if you allow I might help

— Reply to this email directly, view it on GitHub https://github.com/click-contrib/click-repl/issues/93#issuecomment-1476634889, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMPRLRHFZ6DXHDRBXMT43W5CGHHANCNFSM6AAAAAAWBLCIXA. You are receiving this because you were mentioned.Message ID: @.***>

GhostOps77 commented 1 year ago

@auvipy @untitaker if you guys are gonna release this package, please make sure that you've merged this PR as well

Because these guys really need the python 2 support as well also, don't forget to update the version number in the __init__.py file before release, in case you guys have forgot about that

auvipy commented 1 year ago

what's your user? i can add you to pypi … On Mon, Mar 20, 2023, at 18:16, Asif Saif Uddin wrote: yes we should. @untitaker https://github.com/untitaker can you please take a look? or if you allow I might help — Reply to this email directly, view it on GitHub <#93 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMPRLRHFZ6DXHDRBXMT43W5CGHHANCNFSM6AAAAAAWBLCIXA. You are receiving this because you were mentioned.Message ID: @.***>

my pypi username is auvipy same as github and email auvipy@gmail.com same as github

auvipy commented 1 year ago

Could we please get a new release on Pypi (from the current master branch)?

do you need python 2.x support? it is long EOL now

untitaker commented 1 year ago

I invited you to pypi

Who says they need Python 2 support? I only see GhostOps saying that somebody else needs it. I don't think we should act on that unless we have a maintainer that is willing to put effort into maintaining Python 2 compat.

On Tue, Mar 21, 2023, at 16:17, Asif Saif Uddin wrote:

Could we please get a new release on Pypi (from the current master branch)?

do you need python 2.x support? it is long EOL now

— Reply to this email directly, view it on GitHub https://github.com/click-contrib/click-repl/issues/93#issuecomment-1478025238, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMPRJYGJSNWOYWKS64ID3W5HBCDANCNFSM6AAAAAAWBLCIXA. You are receiving this because you were mentioned.Message ID: @.***>

GhostOps77 commented 1 year ago

@untitaker @auvipy I would recommend not to release the module, especially until #92 is solved Don't release it too soon

Also, I would like to be the maintainer for providing the python 2 support, but for that, I need to also setup a python2 test env in gh-actions, might take some time for me. It's pretty complicated to setup a python2 env in GHA

untitaker commented 1 year ago

OP asked for a new release to be cut from master because they are waiting for a fix. I don't think any of this, including this other issue you linked now, is relevant to this discussion. If you personally want py2 support feel free to spend time on it, but lack of installation options in gha is one of many reasons I would be hesitant to support py2.

On Fri, Mar 24, 2023, at 15:28, Ghost Ops wrote:

@untitaker https://github.com/untitaker @auvipy https://github.com/auvipy I would recommend not to release the module until #92 https://github.com/click-contrib/click-repl/issues/92 is solved Don't release it too soon

Also, I would like to be the maintainer for providing the python 2 support, but for that, I need to also setup a python2 test env in gh-actions, might take some time for me. It's pretty complicated to setup a python2 env in GHA

— Reply to this email directly, view it on GitHub https://github.com/click-contrib/click-repl/issues/93#issuecomment-1482896090, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGMPRMR5JFEVTJZLJNMWXTW5WVSJANCNFSM6AAAAAAWBLCIXA. You are receiving this because you were mentioned.Message ID: @.***>

GhostOps77 commented 1 year ago

@untitaker The issue that i've mentioned above (#92) has no relation to python2 I'm saying that this issue must be resolved, as i consider this one as a critical issue, as this affects the functionality of the REPL

And I also agree on your opinion on ignoring python 2, but I would like to implement the python 2 support for this module

auvipy commented 1 year ago

first you can help to fix that. but other then that there are many fixes that a new release can provide. as I have release access now, I can do regular releases now. so there is no need to worry. as for py 2, if it is not a big burden, I will accept that only for one release. but after that the support will be fully dropped.

KSchopmeyer commented 1 year ago

As andy said we would like a new release. However, we would very much like that this new release include the changes in tab-completion and tests for as much of this functionality as possible.

auvipy commented 1 year ago

please allow me some time. I will publish soon. got a new born baby less then 3 weeks ago. ping me again in nexxxt week please

auvipy commented 1 year ago

we got a new release in pypi now! please try and report if you face any issues.