search

click-contrib / click-repl

Subcommand REPL for click apps
MIT License
215 stars 41 forks source link

Added Python 2 support #94

Closed GhostOps77 closed 1 year ago

GhostOps77 commented 1 year ago

Make sure to merge this PR before release, to make this module support python 2 as well

auvipy commented 1 year ago

can you please elaborate why we still need python 2 support?

GhostOps77 commented 1 year ago

@auvipy The guy from this issue

needs python 2 support for his module Removing the support for python 2 from our module will make their job uneasy

And they do requested me to add python 2 feature in his module, as you can see from this issue from their repo pywebm/pywebmtools#1279, they are depended on this module's future release

So, That's why I've decided to introduce python 2 support for this module (again)

For more queries, you can ask the guy from this issue #93 regarding the python 2 support of this & his module

GhostOps77 commented 1 year ago

Sry, closed it by accident Anyway, I'm waiting for your acknowledgement

auvipy commented 1 year ago

why closed?

GhostOps77 commented 1 year ago

@auvipy After some talk with the guy who requested py2 support, I've decided to not to support py2 for this module anymore, and they are ok with that

And don't worry, im implementing some more features on the side, and I'll start pushing PRs to this repo once its all done