search

click-contrib / click_params

Bunch of click parameters to use
Apache License 2.0
31 stars 5 forks source link

Ignore empty string in list param type #14

Closed saroad2 closed 2 years ago

saroad2 commented 2 years ago

Fixes #13

As suggested in the linked issue, one can now choose list parameter types to treat empty strings as empty list. This is a quite common use case that should be treated.

codecov-commenter commented 2 years ago

Codecov Report

Merging #14 (5095139) into master (d5d8a30) will not change coverage. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #14   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           8      8           
  Lines         329    332    +3     
=====================================
+ Hits          329    332    +3
Impacted Files Coverage Δ
click_params/base.py 100% <100%> (ø)
click_params/domain.py 100% <100%> (ø)
click_params/miscellaneous.py 100% <100%> (ø)
click_params/network.py 100% <100%> (ø)
click_params/numeric.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5d8a30...5095139. Read the comment docs.

saroad2 commented 2 years ago

@lewoudar, I added the ability and the documentation :)

saroad2 commented 2 years ago

@lewoudar, Any feedback on this?

lewoudar commented 2 years ago

Thanks @saroad2 for the work :)