Closed laundmo closed 2 years ago
Hi @laundmo thank you for this well-defined pull request Honestly I don't have arguments and feedback against the changes to this parameter, so it is OK for me But the tests are not passing, can you fix them please?
Of course, I'll try. They were passing locally though which makes this quite odd.
Thanks a lot for this PR @laundmo I have to refine a bit the code, but I will try to release a new version by the end of the week
Just noticed i forgot to add to changelog, might be something you want to have a look at.
Yeah I thought about it :)
This PR does a few things with the UnionParamType which i accidentally re-implemented in a project of mine. I fully understand if the changes to the API/usage are not wanted, though personally i find they increase readability a lot.
FirstOf
which is more in line with click names likeChoice
FirstOf(click.INT, click.FLOAT)
(a | b)
Example error of a nested FirstOf (no names given, therefore default union name used):
Checklist: