Closed gutzbenj closed 1 year ago
Base: 100% // Head: 100% // No change to project coverage :thumbsup:
Coverage data is based on head (
d2d14a8
) compared to base (daf87d9
). Patch coverage: 100% of modified lines in pull request are covered.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Ok, seems like Windows CI is not working, I'm sure of the issue, can you try to update dependencies to see if it works better?
Also, I just saw it now, can you remove the private attribute self._convert_called
and the places where it is used in tests, please
Done!
Thanks for the work @gutzbenj I will probably update some dependencies before releasing a new version this week :)
Dear all, dear @lewoudar ,
this PR is meant to show some issue that we ran into within our test suite for wetterdienst at [1]. It accompanies the issue #22 . The second assert would currently fail.
Sincerely, Benjamin
/CC @amotl
[1] https://github.com/earthobservations/wetterdienst