fix behavior of show_default with context_settings

click-contrib / sphinx-click

A Sphinx plugin to automatically document click-based applications

MIT License

212 stars 57 forks source link

fix behavior of show_default with context_settings #131

Closed dylanpilz closed 3 months ago

dylanpilz commented 5 months ago

Summary

Implemented changes requested in #115. Closes #114, closes #115

Tasks

[x] Added unit tests
[x] Added documentation for new features (where applicable)
[x] Added release notes (using reno)
[x] Ran test suite and style checks and built documentation (tox)

Further details

Command.show_defaults overrides show_default, consistent with click version 8.1x

dylanpilz commented 4 months ago

@stephenfin Feel free to take a look at your earliest convenience. Would be great to finally put this to rest

stephenfin commented 3 months ago

Apologies for the delay on this. Can you rebase onto master, squash the commits and run black to fix the lint issues (pre-commit run -a will do the trick). Happy to merge once that's done.

stephenfin commented 3 months ago

Actually, I've just pulled this locally and merged it in. Thanks, @dylanpilz!