search

click-contrib / sphinx-click

A Sphinx plugin to automatically document click-based applications
MIT License
212 stars 57 forks source link

Add support to ppc64le #71

Closed gururajrkatti closed 3 years ago

gururajrkatti commented 3 years ago

Add support to linux on power little endian architecture. sphinx-click is part of ubuntu distribution on this platform also. Continuously building/testing it on ppc64le along with amd64 will ensure that we detect/fix failures if any in the early stage.

stephenfin commented 3 years ago

Thanks for the PR. This is a pure Python library with no C modules. As such, I don't think architecture makes much difference. If the Python interpreter is supported on the host, then this package is supported. This given, I don't think it's wise to merge this so I'm going to close it. If you disagree, please do let me know.

gururajrkatti commented 3 years ago

Hi @stephenfin, thanks for your feedback and response. I agree that if it is a pure python package with no C modules, it should work as it is. However from past experience we have seen even python packages fail on other architectures mostly because of an indirect dependency on native code or libraries via other python dependencies. By continuously building sphinx-click on ppc64le we wish to catch such issues and fix on an ongoing basis. Hope I am clear.