clickbar / laravel-magellan

A modern PostGIS toolbox for Laravel
MIT License
193 stars 11 forks source link

ci: Adjust permissions, Add changelog enforcer, Remove unused, Fix -> Check Styling #40

Closed saibotk closed 1 year ago

saibotk commented 1 year ago

Refactor Styling Workflow to not commit changes anymore, since we use PRs anyways and want to allow the developer to decide on when to run pint. This otherwise only annoys developers, when working on drafts etc. And it also breaks for people without write permissions.

Additionally this PR changes the following:

saibotk commented 1 year ago

I locked it because of all dependencies which might introduce changes. Is there any concern with the committed lock file? Eg. in JS ecosystem it is the go to way and having a reproducible setup is very important.

studnitz commented 1 year ago

Committing the lock file is not the norm for any PHP packages that I know of, so I'm skeptical about that being the solution. And it introduces the need for manually updating the dependencies, which is more work but can be also seen as more correct.

saibotk commented 1 year ago

Yes, that is also what made me skeptical at first, but as i found the answer on the composer page and did not find any other reason for not committing the lock file, i think it brings more value to update the packages manually and not have breaking changes (when hard coding pint / phpstan, we would also need to manually upgrade those anyways).

So do you think of this as a blocker or would this be fine for now?