clickbar / laravel-magellan

A modern PostGIS toolbox for Laravel
MIT License
203 stars 12 forks source link

fix(docblocks): Mitigate issue in ide-helper docblock parsing #69

Closed saibotk closed 8 months ago

saibotk commented 9 months ago

The generation code has some issues with imported class names in docblocks. It does not resolve those properly and thus leads to incorrect annotations. This was mitigated by transforming all current macro annotations to use the fully qualified class names

See https://github.com/barryvdh/laravel-ide-helper/pull/953

Before this PR:

/**
 *
 *
 * @param array|string|\MagellanBaseExpression $groups
 * @return static
 * @see \Clickbar\Magellan\Database\Builder\BuilderMacros::stGroupBy()
 * @static
 */
public static function stGroupBy(...$groups)
{
    return \Illuminate\Database\Query\Builder::stGroupBy(...$groups);
}

After:

/**
 *
 *
 * @param array|string|\Clickbar\Magellan\Database\MagellanExpressions\MagellanBaseExpression $groups
 * @return static
 * @see \Clickbar\Magellan\Database\Builder\BuilderMacros::stGroupBy()
 * @static
 */
public static function stGroupBy(...$groups)
{
    return \Illuminate\Database\Query\Builder::stGroupBy(...$groups);
}