Closed RomainMazB closed 3 months ago
Wow, thank you very very much for the quick response on this! Also this looks very good and much better.
Can we maybe add a simple test case to prevent regressions in the future? Something like a quick model event test? Also a small entry in the changelog would be nice.
Thank you so much!
I just saw, we do not have a proper eloquent test ready, so see this as optional if it is too much for now, we will do it later anyway.
I'll write a test to avoid future regression, it's not a problem.
Probably during the weekend or on Monday.
Just re-thinking about it.
Adding database tests means that github actions will now need to run postgres + postgis to valid the tests.
I am not familiar with github actions so I can't provide a PR on that. What do you recommend?
Dont worry i can add those later thank you 🙏
Oh @RomainMazB, can you quickly run composer fix
and add an entry to the CHANGELOG.md
about this fix?
If not i can also do that :)
@saibotk can you release this fix ?
done @maximepvrt sry should have done that sooner!
This fix #87 by decreasing the code override from the Eloquent Model class.
performInsert
method, we now override thegetAttributesForInsert
method which only cares about getting the attributes to be inserted into the database.performUpdate
method, we now override thegetDirtyForUpdate
method which only cares about getting the modified attributes to be updated into the database.