clickbar / laravel-magellan

A modern PostGIS toolbox for Laravel
MIT License
193 stars 11 forks source link

Overrides getAttributesForInsert & getDirtyForUpdate instead of performInsert & performUpdate to #88

Open RomainMazB opened 1 month ago

RomainMazB commented 1 month ago

This fix #87 by decreasing the code override from the Eloquent Model class.

saibotk commented 1 month ago

Wow, thank you very very much for the quick response on this! Also this looks very good and much better.

Can we maybe add a simple test case to prevent regressions in the future? Something like a quick model event test? Also a small entry in the changelog would be nice.

Thank you so much!

saibotk commented 1 month ago

I just saw, we do not have a proper eloquent test ready, so see this as optional if it is too much for now, we will do it later anyway.

RomainMazB commented 1 month ago

I'll write a test to avoid future regression, it's not a problem.

Probably during the weekend or on Monday.

RomainMazB commented 1 month ago

Just re-thinking about it.

Adding database tests means that github actions will now need to run postgres + postgis to valid the tests.

I am not familiar with github actions so I can't provide a PR on that. What do you recommend?

saibotk commented 1 month ago

Dont worry i can add those later thank you 🙏

saibotk commented 1 month ago

Oh @RomainMazB, can you quickly run composer fix and add an entry to the CHANGELOG.md about this fix?

If not i can also do that :)