search

clickbar / laravel-magellan

A modern PostGIS toolbox for Laravel
MIT License
203 stars 12 forks source link

Update Point.php to update dimension when using setAltitude #92

Closed tmgreensolutions closed 3 months ago

tmgreensolutions commented 3 months ago

I ran into this issue by converting a LineString object via the WKTGenerator to a wkt string. Even though every point has a z value the value is not included in the resulting converted wkt string.

Before the converting is done I am setting new altitude / z values for each point via the setAltitude function. I saw that this function doesn't call the updateDimension function like setZ function would do. When I use the setZ function everything works fine. So I changed the setAltitude function to call the internal setZ function and made this logical change to setLatitude and setLongitude as well.

I hope I have done everything right because this is my first pull request. Please let me know if I made any mistakes.

saibotk commented 3 months ago

Can you fix the linting errors? Otherwise i can do so tomorrow and merge it :)

tmgreensolutions commented 3 months ago

Thank you for your quick response. :) I fixed the linting errors.