Closed clicketyclackety closed 1 year ago
This is actually pretty intuitive in most cases! Well done!
Consider the scenario below:
I don't have a good answer for what should happen, but I find step 6 a bit confusing. Aside from leaving it as is, I can imagine it working a few different ways:
ID: 001
, when User A tries to undo, we do a check and see first undo step affects ID: 001
and last player on that ID was a different user. Therefore this step gets skipped. But next step in undo stack is the line with an ID that was last touched by the same user, so we proceed with undo.Anyway, sorry for the wall of text. I think we should definitely merge this PR as is but think about these scenarios a bit more.
Description
This PR fixes any issues with Undo/Redo, even for release and any other commands.
Fixed Undo / Redo.
Tests
Type of change
Please delete options that are not relevant.