clicketyclackety / Crash

A multi-user implementation of Rhino3d
MIT License
37 stars 5 forks source link

Fixes Undo/Redo #11

Closed clicketyclackety closed 1 year ago

clicketyclackety commented 1 year ago

Description

This PR fixes any issues with Undo/Redo, even for release and any other commands.

Fixed Undo / Redo.

Tests

Type of change

Please delete options that are not relevant.

karimi commented 1 year ago

This is actually pretty intuitive in most cases! Well done!

Consider the scenario below:

  1. User A: creates a circle
  2. User A: moves circle from (0,0,0) to (1,1,1)
  3. User A: releases
  4. User B: deletes the circle
  5. User A: undo
  6. Circle reappears in (0,0,0)

I don't have a good answer for what should happen, but I find step 6 a bit confusing. Aside from leaving it as is, I can imagine it working a few different ways:

Anyway, sorry for the wall of text. I think we should definitely merge this PR as is but think about these scenarios a bit more.