clicketyclackety / Crash

A multi-user implementation of Rhino3d
MIT License
37 stars 5 forks source link

Updated Pipeline to improve consistency #18

Open clicketyclackety opened 1 year ago

clicketyclackety commented 1 year ago

Description

The pipeline does not currently draw any annotations to the right scale. This PR fixes that and adds a lot more support for annotation rendering inside the pipeline. It doesn't give perfect full support (Which is the goal). But it vastly improves it for now.

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

For reference, here is the current level of support, without this PR image

Checklist:

karimi commented 1 year ago

This looks great! I'm not sure why you have the leader say unsupported it works just fine for me crash-leader

One thing I noticed is that the DimAligned and DimAngle preview show the value twice: crash-annotations

clicketyclackety commented 1 year ago

Thanks for taking a look @karimi,

Regarding leaders, this is why -> https://github.com/clicketyclackety/Crash/blob/8502b36ba0caaa78adf253cbf7dcc7f85034cb11/Crash/UI/DrawMethods.cs#L275-L279

I've found that when I use the pipeline. Annotations do not scale correctly and seem very small. So I just drew in the text on top. I'm unsure why yours scales correctly but mine doesn't? Maybe it has something to do with the current DimensionStyle?