search

clickhouse-elixir / clickhouse_ecto

Ecto adapter for ClickHouse database
Apache License 2.0
64 stars 37 forks source link

Possible typo #25

Open florius0 opened 3 years ago

florius0 commented 3 years ago

It seems that I found typo in lib/clickhouse_ecto/storage.ex.

There is a call HTTPoison.start/0 on 70 line. HTTPoison is not listed in deps. Is that call necessary?

sirikid commented 3 years ago

I have no idea what is going on there

https://github.com/clickhouse-elixir/clickhouse_ecto/blob/bc963d3f53bf4264e6fa2b7345c7e3c3dc49d6ee/lib/clickhouse_ecto/storage.ex#L70

sshkarupa commented 2 years ago

@sirikid As far as I see HTTPoison was a dependency for https://github.com/clickhouse-elixir/clickhousex and it was replaced by https://github.com/elixir-mint/mint.

HTTPoison.start() should be removed. There's no reason to keep it.