search

clickhouse-elixir / clickhouse_ecto

Ecto adapter for ClickHouse database
Apache License 2.0
64 stars 37 forks source link

Fix a bug: removed select fields in subquery #6

Closed scarfacedeb closed 6 years ago

scarfacedeb commented 6 years ago

Related: #4

I tried a couple of queries with subqueries and now they all work as expected.

Tbh I'm not sure what was the purpose of put_in call in the first place.

I investigated how Ecto.SubQuery.params is used in postges adapter, and it serves different purpose there.

Perhaps there's some case that I didn't check.

santaux commented 6 years ago

Hi @scarfacedeb, Sorry for late answer. Yes, looks like it helps. Thank you!