search

clickrain / EE_Twitter

EE Add-on that uses oAuth to display Twitter Feed
Other
48 stars 18 forks source link

More logic added to images_only parameter #24

Closed maarten00 closed 11 years ago

maarten00 commented 11 years ago

I've added a few features I needed myself for an implementation:

Now removes image url from text if images_only is set instead of adding an tag. Added display_url to {images}, links to the display page for the image.

bryanburgers commented 11 years ago

Again, thanks for your contributions. I won't be able to look into this for a couple if weeks. If I don't review this in about 2 weeks, go ahead and give another ping.

maarten00 commented 11 years ago

I have tested it some more today, it seems to work fine my way. As far as I can tell it does not produce any warnings or errors. Just to clarify things it's probably better to do it your way. Would you like for me to work that in and create a new pull request?

bryanburgers commented 11 years ago

OK, I did some research on this. My concern was if a photo was before a link, as in this tweet. However, Twitter returns that as two links, not as a link and a media element. I actually can't seem to create a tweet where a photo appears before a link, so I guess you're off the hook because of a technicality on Twitter's part.

So, I'll pull it in.

However, I'll still probably make the change, just be safe, in case Twitter starts returning media elements before url fields. Then we want the same number of replacements.

bryanburgers commented 11 years ago

As always, thanks for your help!