search

clickrain / EE_Twitter

EE Add-on that uses oAuth to display Twitter Feed
Other
48 stars 18 forks source link

Updated _build_relative_date to be a little more... human. #27

Closed markdrzy closed 11 years ago

markdrzy commented 11 years ago

Ugh. Bryan, wait on this pull request. I need to do some further testing.

bryanburgers commented 11 years ago

@mark-cr The current implementation of _build_relative_date returns a timestamp that conforms to the Twitter Display Requirements ("Tweet Timestamp" under "Timelines"). I'd like to keep it that way. If you're interested in using a different human-readable format, can we put it in a different tag?

Also, it seems like pretty much everybody runs into the {relative_date} issue where it pulls from the outer {exp:channel:entries} loop, rather than the {exp:twitter:*} loop. Maybe we need to rename that guy to prevent collisions and confusion.

bryanburgers commented 11 years ago

@mark-cr FYI: I opened a new issue (#28) for renaming the existing {relative_date} tag to something that doesn't collide and confuse.

markdrzy commented 11 years ago

Are you comfortable with {twitter_relative_date} and {better_relative_date}?

bryanburgers commented 11 years ago

Yes and yes.

markdrzy commented 11 years ago

@bryanburgers - When you get a moment, please review these changes. I think I'm done now.

bryanburgers commented 11 years ago

Looks good. Thanks, Mark.