clickrain / EE_Twitter

EE Add-on that uses oAuth to display Twitter Feed
Other
48 stars 18 forks source link

Validation #33

Closed Third-Hyperion closed 10 years ago

Third-Hyperion commented 10 years ago

Is there a way to disable the #taglinks OR link them to a relevant place because at the moment the links don't go anywhere and this is causing my page to not validate.

Cheers,

Wes.

bryanburgers commented 10 years ago

Where are the links going? Where do you expect them to go?

What version of ExpressionEngine are you running? What version of EE_Twitter are you running?

Third-Hyperion commented 10 years ago

Hi,

Running expression engine ver 2.7.3 and EEtwitter ver 1.7.0

This an example of the validation error and the same error for other #hashtags or @EEtwitter links.

Error Line 407, Column 97: Bad value for attribute target on element a: Browsing context name must be at least one character long.

…ttp://twitter.com/search?q=%23buget14'>#buget14 drink a <a target='' title…

Syntax of browsing context name or keyword: A browsing context name or keyword is either any string that does not start with an underscore (_) or a string that case-insensitively matches one of: _blank, _self, _parent, or _top.

If i could in some way make the #hashtags and @EEtwitters just appear as plain text rather than a link is that possible?

Cheers,

Wes.

bryanburgers commented 10 years ago

OK, so according to that, the issue is not with the a's href attribute, but rather with its title attribute. Since you're not specifying a title, EE_Twitter is outputting title='' when it should just be outputting nothing. I can work on fixing that when I get a chance.

EE_Twitter does not currently have a way to keep mentions, hashtags, and urls as plain text. That would not be very high on my priority list. If that would be useful to you, please submit a pull request.

Third-Hyperion commented 10 years ago

This is an example of another anchor, produced by EEtwitter.

<a href="http://twitter.com/search?q=%23GwynethPaltrowandChrisMartin" title="Search for GwynethPaltrowandChrisMartin" target="">#GwynethPaltrowandChrisMartin

A title is being produced? however an appropriate target is not being created?

Cheers for the help,

Wes.