[object Object] error on thumbnail

clickrain / videolink

Video Link is a Field Type add-on for ExpressionEngine that enables easy and user-friendly embedding of user-defined YouTube and Vimeo videos.

MIT License

15 stars 6 forks source link

[object Object] error on thumbnail #16

Closed petenice closed 9 years ago

petenice commented 9 years ago

{my_field_name:thumbnail} returning [object Object] error

bryanburgers commented 9 years ago

@petenice Thanks for reporting this issue. Would you mind answering a few questions so I can get to the bottom of this?

What version of videolink are you using?
Are you trying to embed a YouTube video or a Vimeo video?
What browser were you using to access the control panel when you embedded the video?
Does that tag return "[object Object]" or "[object Object] error"?
Does this occur when you resave an existing entry? Or does it occur when you create a new entry?

petenice commented 9 years ago

Sorry about the delay. Answers follow:

VideoLink 1.5.0
Trying to embed YouTube video
Browsering with Chrome 43
I believe it returned "[object Object]"
Error occured when creating a new entry

Thank you for your excellent work and helpful contribution! It's a great tool.

peteheaney commented 9 years ago

I was going to create a new issue, but I think this is probably the same thing....

The JSON feed returned by the YouTube API has changed. You need to update videolink.js. Change line 34 from:

'thumbnail': data.items[0].snippet.thumbnails.maxres

to:

'thumbnail': data.items[0].snippet.thumbnails.high.url

bryanburgers commented 9 years ago

@peteheaney Thanks for finding that! Would you be willing to submit a pull request?

bryanburgers commented 9 years ago

@petenice I believe this is fixed because of Pull Request #18. I've merged that into master. Can you give that a try to see if it fixes your problem before I cut a release?

petenice commented 9 years ago

Success! Thank you both!