clickrain / videolink

Video Link is a Field Type add-on for ExpressionEngine that enables easy and user-friendly embedding of user-defined YouTube and Vimeo videos.
MIT License
15 stars 6 forks source link

YouTube embeds in IE stack on top of all other z-indexed items #6

Open bfopma opened 10 years ago

bfopma commented 10 years ago

Consider adding &wmode=transparent and wmode="Opaque" to iframe on line 279. I'm unsure if there are use cases where we would not want this.

bryanburgers commented 10 years ago

The wmode=opaque answer is the accepted answer for YouTube on Stack Overflow.

This post suggests that the default is already wmode=opaque for Vimeo videos.

Because of this, I suggest that we just default YouTube to a default opaque wmode, without providing an option in the tag itself. I don't see this is a huge breaking change that will bite people who upgrade Video Link, so I don't think we need to be backward-compatible by leaving the default as wmode=window, and requiring the user to opt-in to wmode=opaque.

wmode is described in the Adobe documentation, and it seems that opaque and transparent are the same, except transparent lets you see through the Flash page and opaque is fater. But I don't think YouTube videos have transparency, so I'd opt for opaque.