search

clickrain / videolink

Video Link is a Field Type add-on for ExpressionEngine that enables easy and user-friendly embedding of user-defined YouTube and Vimeo videos.
MIT License
15 stars 6 forks source link

Ability to pass additional querystring vars #7

Closed nathanpitman closed 10 years ago

nathanpitman commented 10 years ago

It would be neat to be able to pass additional embed querystring vars, i.e. we often want to hide the 'info bar' for YouTube vids... showinfo=0

:)

bryanburgers commented 10 years ago

@nathanpitman Agreed. I also want this. (Sorry for the slow response.)

I'm thinking through the API here.

{videolink-field:embed
    width="..."
    height="..."
    youtube:controls="2"
    youtube:showinfo="0"
    vimeo:other="x"}

If this is a YouTube embed, we'd get //www.youtube.com/embed/1234?rel=0&controls=2&showinfo=0. If it's a Vimeo embed, we'd get //player.vimeo.com/video/1234?other=x.

I like this API. It seems intuitive enough.

I think we also need to think about how we're going to pass parameters to the <iframe> tag itself, instead of the embed URL. (See #6.) This syntax would let us do iframe:wmode="Opaque". Would a user would ever want to pass an iframe parameter to just a YouTube iframe, or to just a Vimeo iframe? Then what's the parameter? iframe:youtube:wmode="Opaque"?

We only support Vimeo and YouTube right now, and both are embedding using an <iframe>. So it's probably too early to think about what we would do if we needed to support a service that uses <embed>.

@nathanpitman @mark-cr @bfopma @cmtracy Thoughts? Does this syntax look alright? Does the iframe:parameter="..." syntax look acceptable?

nathanpitman commented 10 years ago

Syntax looks good, RE iFrames/Embeds... does anyone provide embed only support these days? The general trend seems to be towards iFrame over embed so perhaps there's no need to worry too much about embeds? iFrames generally provide better support across devices so I can't see this trend changing anytime soon. :)