Unconsistent record overlay and no versionOL

clickstorm / cs_seo

[clickstorm] SEO

Other

33 stars 49 forks source link

Unconsistent record overlay and no versionOL #235

Closed dogawaf closed 5 years ago

dogawaf commented 5 years ago

Hello

When getting a record from the database with a SQL query, the overlay and versionOL must be applied in frontend context, with $GLOBALS['TSFE']->sys_page->getRecordOverlay() and $GLOBALS['TSFE']->sys_page->versionOL()

In Service/MetaDataService.php#L142, call to getRecordOverlay must be done in any case (TYPO3 will take care of overlaying or not) and call to versionOL must be added.

I can make a PR if your are agree.

mhirdes commented 5 years ago

ok, imo the versionOL is not so important, because Google and get the live version. But if you will add a PR I can apply your changes.

dogawaf commented 5 years ago

For versionOL, I have users that wan't to "preview" changes in seo fields on the draft workspace.

I will make a PR.

dogawaf commented 5 years ago

I've submited two PR: one for master, and the same fix for 3.x.