clickstorm / cs_seo

[clickstorm] SEO
Other
33 stars 49 forks source link

minDescription being forced due to faulty condition #328

Closed fjacobi closed 5 months ago

fjacobi commented 7 months ago

Hej, during an upgrade I just ran into this issue.

https://github.com/clickstorm/cs_seo/blob/main/Configuration/TCA/Overrides/pages.php#L16

The field is a boolean, so it's never empty?

mhirdes commented 7 months ago

For me it works. Can you check it again?

https://www.php.net/manual/en/function.empty.php

Returns true if var does not exist or has a value that is empty or equal to zero, aka falsey, see conversion to boolean. Otherwise returns false.

https://onlinephp.io?s=s7EvyCjg5eLlUsmtDEssUrBVSEvMKU61Bgllpmmk5haUVGpA5DQ1Fap5uThTkzPyFdQ9ixXAcurWnLxctQqpQD2osnn5JTAVQAUA&v=8.2.13