clicon / clixon-controller

Clixon network controller
Apache License 2.0
12 stars 4 forks source link

"show compare" should show device name #63

Open krihal opened 7 months ago

krihal commented 7 months ago

Just as "commit diff" the device name should be included for "show compare":

snc@snc-lab[/]# commit diff
juniper1:
         <login xmlns="http://yang.juniper.net/junos/conf/root">
+           <user>
+              <name>testing</name>
+              <full-name>testing</full-name>
+              <class>super-user</class>
+           </user>
         </login>
juniper2:
OK
snc@snc-lab[/]# show compare
                  login {
+                    user testing {
+                       full-name testing;
+                       class super-user;
+                    }
                  }
olofhagsand commented 7 months ago

What to with non-device data? That is, you can change config for services/processes or something else.

krihal commented 7 months ago

Maybe add a service section etc?

snc@snc-lab[/]# show compare
juniper1:
                  login {
+                    user testing {
+                       full-name testing;
+                       class super-user;
+                    }
                  }
juniper2:
                  login {
+                    user testing {
+                       full-name testing;
+                       class super-user;
+                    }
                  }
services:
               ssh-users {
                  sunet {
+                    user testing {
+                       full-name testing;
+                       class super-user;
+                    }
                  }
               }
denniswa commented 7 months ago
 devices {
     device router-r {
         config {
             junos:configuration {
                 system {
-                    domain-name sunet.se;
+                    domain-name orvar;
                 }
             }
         }
     }
 }