clicon / clixon

YANG-based toolchain including NETCONF and RESTCONF interfaces and an interactive CLI
http://www.clicon.org/
Other
208 stars 70 forks source link

Config user and group #452

Closed pprindeville closed 11 months ago

pprindeville commented 1 year ago

Various fixes to native tests, especially trying to run the tests as the same user or group that they'll use in the wild.

olofhagsand commented 1 year ago

I also have this problem for vagrant tests:

olof@nuc1:~/src/clixon/test/vagrant$ cat site.mk
VAGRANTS = ubuntu/bionic64
RESTCONF = native
olof@nuc1:~/src/clixon/test/vagrant$ make
with_restconf=native ./vagrant.sh ubuntu/bionic64 2>&1 | tee "logs/vagrant-native-ubuntu-bionic64.log"
...
Running test_api.sh
Generating a RSA private key
.........+++++
.......................................................................+++++
writing new private key to '/var/tmp/./test_api.sh/certs/clixon-ca-key.pem'
-----
.....+++++
....................................................................................+++++
Signature ok
subject=CN = localhost, emailAddress = olof@hagsand.se, O = Clixon, L = Stockholm, C = SE
Getting CA Private Key
Test 1(1) [compile /var/tmp/./test_api.sh/example-api.c]
Test 2(2) [test params: -s init -f /var/tmp/./test_api.sh/conf_yang.xml]
Test 3(3) [kill old backend]
Sep  5 10:05:40: Killing old daemon with pid: 22806
Test 4(4) [start backend]
Test 5(5) [wait backend]
Sorry, user vagrant is not allowed to execute '/usr/local/bin/clixon_netconf -q1ef /var/tmp/./test_api.sh/conf_yang.xml' as vagrant:clicon on ubuntu-bionic64.

That is probably due to user/group setup in https://github.com/clicon/clixon/blob/b8f4dbd8d1669e0aa606f8f4c57d3282de0a16bc/test/vagrant/clixon.sh#L14

olofhagsand commented 1 year ago

I also have this problem in valgrind for backend test_nacm_module_read.sh which I do not see in master

 sh> pattern=test_nacm_module_read.sh ./mem.sh backend
 ...
==2215398== LEAK SUMMARY:
==2215398==    definitely lost: 0 bytes in 0 blocks
==2215398==    indirectly lost: 0 bytes in 0 blocks
==2215398==      possibly lost: 0 bytes in 0 blocks
==2215398==    still reachable: 1,256,994 bytes in 16,859 blocks
==2215398==         suppressed: 2,891 bytes in 8 blocks
==2215398== 
==2215398== For lists of detected and suppressed errors, rerun with: -s
==2215398== ERROR SUMMARY: 0 errors from 0 contexts (suppressed: 0 from 0)
pprindeville commented 12 months ago

At this time, these tests aren't running: test_privileges.sh test_config_dump.sh test_yang_models_ieee.sh

The test_config_dump.sh seems to run, but there's a discrepancy between what it expects and what it gets.

pprindeville commented 12 months ago

I also have this problem for vagrant tests:

olof@nuc1:~/src/clixon/test/vagrant$ cat site.mk
VAGRANTS = ubuntu/bionic64
RESTCONF = native
olof@nuc1:~/src/clixon/test/vagrant$ make
with_restconf=native ./vagrant.sh ubuntu/bionic64 2>&1 | tee "logs/vagrant-native-ubuntu-bionic64.log"
...
Running test_api.sh
Generating a RSA private key
.........+++++
.......................................................................+++++
writing new private key to '/var/tmp/./test_api.sh/certs/clixon-ca-key.pem'
-----
.....+++++
....................................................................................+++++
Signature ok
subject=CN = localhost, emailAddress = olof@hagsand.se, O = Clixon, L = Stockholm, C = SE
Getting CA Private Key
Test 1(1) [compile /var/tmp/./test_api.sh/example-api.c]
Test 2(2) [test params: -s init -f /var/tmp/./test_api.sh/conf_yang.xml]
Test 3(3) [kill old backend]
Sep  5 10:05:40: Killing old daemon with pid: 22806
Test 4(4) [start backend]
Test 5(5) [wait backend]
Sorry, user vagrant is not allowed to execute '/usr/local/bin/clixon_netconf -q1ef /var/tmp/./test_api.sh/conf_yang.xml' as vagrant:clicon on ubuntu-bionic64.

That is probably due to user/group setup in

https://github.com/clicon/clixon/blob/b8f4dbd8d1669e0aa606f8f4c57d3282de0a16bc/test/vagrant/clixon.sh#L14

Okay, how to fix that. Add vagrant to the clicon group?

pprindeville commented 11 months ago

Doesn't seem like this is going to be accepted for 6.4.0, or at all.