search

clicon / clixon

YANG-based toolchain including NETCONF and RESTCONF interfaces and an interactive CLI
http://www.clicon.org/
Other
206 stars 69 forks source link

Create python func #522

Closed khromenokroman closed 1 month ago

khromenokroman commented 2 months ago

I fixed the code and took into account your comments

khromenokroman commented 2 months ago

@olofhagsand Made the function more versatile

khromenokroman commented 1 month ago

@olofhagsand I don't really understand the project yet, I wanted to clarify, I need to look at why the Error in test failed test_restconf_callhome.sh errcode=255 and Error in test_restconf_ssl_certs.sh errcode=255 I have not made any changes to the restconf functionality

khromenokroman commented 1 month ago

@olofhagsand When I check in, I'm fine Снимок экрана от 2024-05-27 16-13-31 I did it on my computer according to the documentation https://github.com/clicon/clixon/blob/master/test/README.md Getting started

olofhagsand commented 1 month ago

@olofhagsand I don't really understand the project yet, I wanted to clarify, I need to look at why the Error in test failed test_restconf_callhome.sh errcode=255 and Error in test_restconf_ssl_certs.sh errcode=255 I have not made any changes to the restconf functionality

No, its something with the regression test context, maybe alpine libssl or curl upgraded to something where some ssl operations fail. Looking into it, not related to this, other tests fail as well.

olofhagsand commented 1 month ago

@olofhagsand I don't really understand the project yet, I wanted to clarify, I need to look at why the Error in test failed test_restconf_callhome.sh errcode=255 and Error in test_restconf_ssl_certs.sh errcode=255 I have not made any changes to the restconf functionality

No, its something with the regression test context, maybe alpine libssl or curl upgraded to something where some ssl operations fail. Looking into it, not related to this, other tests fail as well.

This should work now, please rebase

khromenokroman commented 1 month ago

@olofhagsand I made changes, but I can't somehow run CI at home to check the correctness of the changes made, and not to bother you

olofhagsand commented 1 month ago

@olofhagsand I made changes, but I can't somehow run CI at home to check the correctness of the changes made, and not to bother you Just run 'make test' on the top-level.

khromenokroman commented 1 month ago

@olofhagsand I made changes, but I can't somehow run CI at home to check the correctness of the changes made, and not to bother you Just run 'make test' on the top-level.

Thanks

khromenokroman commented 1 month ago

But it still opens a way to run a random program from the CLI, ie as a user of the CLI which is probably not a good idea for a product.

and how can the user run any program, the cli-spec is available only to the administrator, only he can add a call to which script there, the user can only select the pre-defined scripts that the administrator has set, or do I not understand something?

khromenokroman commented 1 month ago

@olofhagsand @dima1308 work is done?

olofhagsand commented 1 month ago

Related: could one do something along the lines with: https://github.com/MontaVista-OpenSourceTechnology/clixon-backend-helper for CLI python scripts?

khromenokroman commented 1 month ago

Related: could one do something along the lines with: https://github.com/MontaVista-OpenSourceTechnology/clixon-backend-helper for CLI python scripts?

I'm not as well versed in the project as you are, as well as python and C to give an answer, but I'll read about it :)