search

client-go / unofficial-docs

A home for unofficial client-go docs
Apache License 2.0
22 stars 2 forks source link

Copy Makefile and .sass files from kubernetes/website and update them to match our current CSS #7

Closed xmudrii closed 6 years ago

xmudrii commented 6 years ago

This PR copies the Makefile and .sass files from the kubernetes/website repo.

The Makefile ensures we can easier regenerate the CSS files from .sass files, as well as easier build the website.

The CSS/sass regeneration depends on the node-sass package, which can be obtained from npm, such as npm install -g node-sass. I've added a note about this to Makefile and Makefile help.

The CSS files are regenerated using the make sass command.

The .sass files are updated to match our current CSS. Maybe there's something left unnoticed, but I'll try to fix that as well.

Closes #3 /area hugo /cc @nikhita @LiliC @munnerz

nikhita commented 6 years ago

@xmudrii thank you, thank you, thank you! :)

I'll try to take a look at this later today but fair warning: my CSS skills are equivalent to

The Essential art of Changing Stuff and Seeing What Happens https://twitter.com/thepracticaldev/status/720257210161311744

so I'd appreciate if anyone else took a deeper look at it. :smile:

xmudrii commented 6 years ago

I'll try to take a look at this later today but fair warning: my CSS skills are equivalent to

The Essential art of Changing Stuff and Seeing What Happens https://twitter.com/thepracticaldev/status/720257210161311744

Same, but the website looks same as before, so I hope I've got it right. :smile:

munnerz commented 6 years ago

This seems sensible to me, and solves #3 😄

I did not spend much time adjusting the CSS when first porting things across, so I think we should accept this (because progress!) and push ahead! 💯

(let's also test tide merging for the first time...) /lgtm /approve

munnerz commented 6 years ago

/approve

k8s-ci-robot commented 6 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/client-go/unofficial-docs/blob/master/OWNERS)~~ [munnerz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xmudrii commented 6 years ago

Sounds good! I'll try to poke around the website bit more to fix some issues, when I have some more free time. I'm still a CSS beginner though, but I think I can help with some minor issues. Also, that's a good practice. :smile:

I created #8 for a comment you left, that's a great idea! I'll try to fix that one as well. :)