search

client9 / misspell

Correct commonly misspelled English words in source files
MIT License
1.35k stars 114 forks source link

Switch to xurls for the url regexp #100

Closed mvdan closed 6 years ago

mvdan commented 7 years ago

Avoids having to roll a separate regexp. It's also more aggressive, matching anything that looks like a URL instead of trying to only match correct URLs.

All the removed test cases now match as urls and are replaced with blank space, which is good since they wouldn't be potential misspellings anyway.

mvdan commented 7 years ago

Well, it seems like the travis-makefile combo doesn't actually go get anything. And since language: go isn't present, Travis doesn't do it on its own either.

I'll let you decide what to do about this.

client9 commented 7 years ago

Thanks for the PR,

Was the existing URL matching causing problems with false-positives? Or just being proactive :-) I'd prefer not introducing extra dependencies unless critical, but I'll take a look.

thanks!

n

mvdan commented 7 years ago

It was causing problems a while back when I ran this on a codebase, but to be honest I don't remember the details now.

mvdan commented 7 years ago

Bump?