search

client9 / misspell

Correct commonly misspelled English words in source files
MIT License
1.35k stars 114 forks source link

Line # is off by 1 #9

Closed shawnps closed 8 years ago

shawnps commented 8 years ago 
➜  goreportcard [master] misspell repos/src/github.com/google/go-github/tests/integration/repos_test.go 
repos/src/github.com/google/go-github/tests/integration/repos_test.go:34: corrected "non-existant" -> "non-existent"

Says it's line 34, but the word doesn't appear in that line:

➜  goreportcard [master] cat -n repos/src/github.com/google/go-github/tests/integration/repos_test.go | grep 34
    34              if resp.StatusCode == http.StatusNotFound {

It's in the next line, 35:

➜  goreportcard [master] cat -n repos/src/github.com/google/go-github/tests/integration/repos_test.go | grep 35
    35                  // found a non-existant repo, perfect
shawnps commented 8 years ago

https://github.com/client9/misspell/pull/10

client9 commented 8 years ago

pull request merged in.