client9 / stringencoders

Fast c-string transformations
MIT License
135 stars 51 forks source link

End requirement for stdint.h (mainly to work towards a Win32/64 compile) #14

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
stdint.h is not supplied on Windows. This is highly unfortunate but it's fairly 
easy to get around.

Attached is a patch that changes all <stdint.h> includes to a "modp_stdint.h". 
The include order is changed to still follow the preferred order of: the 
corresponding .h for this .c, std C stuff, std C++ stuff, system stuff, our 
stuff. If _WIN32 is defined (which is true for Win32/64), we define the 
u?int(8|16|32|64)_t types. Otherwise, #include <stdint.h>.

Nothing other than these types is defined for Windows but that's all that is 
currently necessary, I think. I found no uses of the *_MIN, *_MAX, *_C, macros.

This removes one challenge of adding Windows support.

Original issue reported on code.google.com by gavinbea...@gmail.com on 29 Aug 2010 at 9:25

Attachments:

GoogleCodeExporter commented 9 years ago
Sorry! The patch is missing modp_stdint.h.

Use 0002.

Original comment by gavinbea...@gmail.com on 29 Aug 2010 at 9:31

Attachments:

GoogleCodeExporter commented 9 years ago
How did I missed this!

Thank you so much.  This is just what we needed.

I took a new job and completely forgot about these tickets.

--nickg

Original comment by nickgsup...@gmail.com on 30 Sep 2010 at 2:43

GoogleCodeExporter commented 9 years ago
Commited in revision 239

thanks again!

Original comment by nickgsup...@gmail.com on 30 Sep 2010 at 2:46

GoogleCodeExporter commented 9 years ago
Making as fixed, but reopen if this is incorrect.

Original comment by nickgsup...@gmail.com on 13 Aug 2012 at 10:43