clientIO / appmixer-module-aws

Appmixer Infrastructure-as-Code Terraform module for AWS.
Apache License 2.0
0 stars 0 forks source link

bug: `terraform plan` fails with empty zone_id #2

Closed jirihofman closed 8 months ago

jirihofman commented 8 months ago

Summary

No response

Issue Type

Bug Report

Terraform Version

terraform --version
Terraform v1.7.0
on darwin_amd64
+ provider registry.terraform.io/cloudposse/template v2.2.0
+ provider registry.terraform.io/cloudposse/utils v1.15.0
+ provider registry.terraform.io/hashicorp/aws v5.33.0
+ provider registry.terraform.io/hashicorp/http v3.4.1
+ provider registry.terraform.io/hashicorp/local v2.4.1
+ provider registry.terraform.io/hashicorp/null v3.2.2
+ provider registry.terraform.io/hashicorp/random v3.6.0
+ provider registry.terraform.io/hashicorp/time v0.10.0

Your version of Terraform is out of date! The latest version
is 1.7.1. You can update by downloading from https://www.terraform.io/downloads.html

Steps to Reproduce

appmixer plan
# then enter `appmixer.co` when prompted for "Root DNS name, must be applicable to route53 zone (zone_id)"

Not sure what values are supposed to be there.

Expected Results

No error

Actual Results

...
...
...

╷
│ Warning: Argument is deprecated
│ 
│   with module.document_db_ssm_password.aws_ssm_parameter.default["/cio-dev-appmixer/documentdb/master_password"],
│   on .terraform/modules/document_db_ssm_password/main.tf line 22, in resource "aws_ssm_parameter" "default":
│   22:   overwrite       = each.value.overwrite
│ 
│ this attribute has been deprecated
│ 
│ (and 6 more similar warnings elsewhere)
╵
╷
│ Error: zone_id must not be empty, got 
│ 
│   with aws_route53_record.alb[0],
│   on route53.tf line 9, in resource "aws_route53_record" "alb":
│    9:   zone_id = var.zone_id
│ 
╵
╷
│ Error: zone_id must not be empty, got 
│ 
│   with aws_route53_record.cert_alb["*.appmixer.co"],
│   on route53.tf line 42, in resource "aws_route53_record" "cert_alb":
│   42:   zone_id         = var.zone_id
Riqardos commented 8 months ago

Fixed in PR