search

cliffano / bagofrequest

A bag-of-holding containing request utility functions
MIT License
1 stars 3 forks source link

pass agentOptions to underlying request options #5

Closed benediktarnold closed 9 years ago

benediktarnold commented 9 years ago

Hi,

in order to use client side SSL authentication with nestor, I made a small fix to bagofrequest to pass agentOptions to the underlying request instance. See https://github.com/request/request#tlsssl-protocol

Regards, Ben PS: I have a working prototype of nestor with client side ssl authentication. That need's some cleanup and I make a pull request for that as well.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 20da3b7f0fcd784825b256b66bafe8ef6b7b63cb on benediktarnold:agentoptions into 25f0254acbd0098360beaebddb35266ccf25ae32 on cliffano:master.

coveralls commented 9 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 20da3b7f0fcd784825b256b66bafe8ef6b7b63cb on benediktarnold:agentoptions into 25f0254acbd0098360beaebddb35266ccf25ae32 on cliffano:master.

cliffano commented 9 years ago

Merged, and published to npm as bagofrequest v0.1.2 . Thanks again for the contrib. Looking forward to the nestor ssl contrib.