search

cliffano / nestor

Jenkins CLI and node.js client
http://blog.cliffano.com/tag/nestor/
MIT License
182 stars 27 forks source link

first implementation of ssl client certificate authentication #32

Closed benediktarnold closed 9 years ago

benediktarnold commented 9 years ago

Hi, as already mentioned, I am working on a client certificate authentication. This commit is far from perfect - I see it as a starting point for a discussion. I would say it is in a works for me state and needs some refactoring. Please let me know, what you think.

Cheers, Ben

benediktarnold commented 9 years ago

Sorry. I forgot to run the test. Will fix them as soon as possible.

cliffano commented 9 years ago

Sorry, life got busy and I could only look at this a month later. I couldn't merge the PR using GH due to conflict in package.json, so I did it via the command line. Your name and GH username are also credited in the changelog.

Don't worry about refactoring, I'll only need to do a little bit of tidying up and updating the unit tests.