NO_PROXY environment variable is not used for ignoring proxy settings

cliffano / nestor

Jenkins CLI and node.js client

http://blog.cliffano.com/tag/nestor/

MIT License

182 stars 27 forks source link

NO_PROXY environment variable is not used for ignoring proxy settings #36

Closed prinztob closed 8 years ago

prinztob commented 8 years ago

Hi, Currently only localhost and 127.0.0.1 are used for ignoring proxy settings. Is there any plans to use the NO_PROXY environment variable for this in the future?

Many Regards, Tobias

cliffano commented 8 years ago

I've included NO_PROXY/no_proxy support in nestor v0.3.5 . Could you please give it a try and see if it solves your problem?

cliffano commented 8 years ago

@prinztob Would you be able to give nestor v0.3.5 a quick try?

prinztob commented 8 years ago

Thanks a lot, I just tested it and your NO_PROXY/no_proxy support solves my problem.

cliffano commented 8 years ago

@prinztob Thanks for your help with testing. Closing this issue now that it's solved.