search

cliffrowley / atom-open-in-github-app

Atom package to open the current project in GitHub.app
MIT License
5 stars 1 forks source link

Replacing deprecated workspaceView Call #5

Closed pwalker91 closed 9 years ago

pwalker91 commented 9 years ago

Per changes to package API in atom 1.76+, workspaceView has been replaced with views.getView(atom.workspace)

cliffrowley commented 9 years ago

Thanks for this, I will merge it in with the next patch :+1:

jrsconfitto commented 9 years ago

LGTM! Thanks :smile:

cliffrowley commented 9 years ago

@jugglingnutcase it's just come to my attention that you can also push to apm since you are a contributor - so feel free to push this as a patch release (e.g. merge here, pull local, then apm publish patch)

jrsconfitto commented 9 years ago

Cool... i'd be happy too. i'll roll in the other PR as well.

jrsconfitto commented 9 years ago

i'll probably do it tonight or tomorrow at some point.

jrsconfitto commented 9 years ago

Hey @pwalker91! i took a look into merging this, and this patch actually doesn't work! i thought it would, but as it turns out the command doesn't fire properly. :cry:

i found a line that will work well as a fix from atom's package creation tutorial and will adjust your code with it. Thanks for your hard work and willingness to contribute! :smile:

jrsconfitto commented 9 years ago

OK, i merged this in manually. i'll deploy the package soon. Thanks again.