Extremely high CPU usage when shuffling

clifordsymack / Electron-Cash

Electrum; Bitcoin thin client

MIT License

6 stars 3 forks source link

Extremely high CPU usage when shuffling #22

Closed cculianu closed 5 years ago

cculianu commented 5 years ago

Symptoms:

The app becomes unresponsive or very slow to respond
The gui is sluggish
CPU usage is 100% on 1 core.

Likely suspects:

More code review needed in the internals -- likely there is some more busy-looping happening
It's possible the crypto code is using python native calls and is slow. Needs investigation.

cculianu commented 5 years ago

Update:

This might be due to GUI update spamming from the cashshuffle plugin as it processes protocol messages.

Will investigate.

cculianu commented 5 years ago

Update 2: It turns out it's the code in coins.py -- the ecdsa and elliptic curve crypto functions.

TODO: Figure out if we can use native libs for this like libsecp256k1, etc.

cculianu commented 5 years ago

Update 3: We need to use native ecc libs. We should pull this commit in from electrum and modify the packaging of the app to use the libsecp256k1 libs:

https://github.com/spesmilo/electrum/blob/master/electrum/ecc_fast.py

cculianu commented 5 years ago

Ok, I pulled in the native libsecp256k1 support. Fixed by commit 612596a747a7192731a2a0a4f58063d98c41a833