clifordsymack / Electron-Cash

Electrum; Bitcoin thin client
MIT License
6 stars 3 forks source link

Warning when choosing to spend unshuffled coins #71

Closed imaginaryusername closed 5 years ago

imaginaryusername commented 5 years ago

When choosing radio button to send "unshuffled" coins, there should be a fat warning (perhaps in the form of a popup, so it cannot be ignored). Spending unshuffled is not only privacy reducing for incoming coins, but also potentially compromise coins from past shuffles - change from spending shuffled outputs are binned together with incoming coins. There are longer term fixes that address this, but before it can be addressed, the UI should discourage people from spending unshuffled.

Possible text:

"You are now spending UNSHUFFLED coins. Spending and linking these coins may compromise your privacy not only for new received coins, but also from your past spending of shuffled coins. Are you sure?"

cculianu commented 5 years ago

I do think it's surprisingly easy for nubs to spend unshuffled if the app has remained in that state.

I can easily add this popup with a little tiny 'don't ask me this again' in the corner (only to be polite, of course).

I am having trouble understanding this though:

Spending unshuffled is not only privacy reducing for incoming coins, but also potentially compromise coins from past shuffles - change from spending shuffled outputs are binned together with incoming coins.

I'm having trouble wrapping my head around this one... wouldn't an easy fix be just to always use a brand spanking new change address for each spending tx?

imaginaryusername commented 5 years ago

@cculianu yes, using a new change address is default behavior already, but when spending larger amounts you'll combine coins (in the same bucket), and that's where troubles begin. 😬

cculianu commented 5 years ago

@imaginaryusername Hmm... I'm still having trouble understanding this but chainalysis woes are not my forte. :)

Here is what it looks like now on macOS. I'm getting ready to commit this dialog. Note it pops up whenever you select that radio and even if you left that mode "on" last run, next run it pops up again..

screen shot 2019-02-27 at 6 38 28 pm