search

clifordsymack / Electron-Cash

Electrum; Bitcoin thin client
MIT License
6 stars 3 forks source link

Warning when disabling Cashshuffle plugin #80

Closed imaginaryusername closed 5 years ago

imaginaryusername commented 5 years ago

Similar to #71 , when clicking (or at password failure) resulting in cashshuffle status going from enabled -> disabled, there should be a popup that warns users. Potential text:

"You are now disabling Cashshuffle plugin on a wallet that had it enabled. Spending and linking coins may compromise your privacy for both unshuffled and shuffled coins in this wallet. Are you sure?"

If "No" is clicked, ideally the response differs according to what happened before (if manual disable, it reverts to enabled; if password failure, password is prompted again). If that is complicated to implement, though, the dialogue can forgo the "No" button and just have an "I understand" button.

cculianu commented 5 years ago

Okay. I guess we're really hammering home this "unshuffled is bad.. mmmmkayyy" message, huh? :)

I might not nag users about it until they have at least completed 1 shuffle and/or only nag them if it truly is a situation where they have had the plugin "on" in the past.

Although that adds a bit of noise to the code -- so I may just nag unconditionally... we'll see. But I guess I am going to do this - despite my dislike for nag screens in general... it feels.. Applesque. :)

cculianu commented 5 years ago

Password prompt cancelled nag (only appears if the internal per-wallet cashshuffle session counter is >0):

screen shot 2019-02-28 at 11 29 40 am

Generic disable nag if clicking icon, etc:

screen shot 2019-02-28 at 11 31 42 am

Let me know what you think @imaginaryusername -- I'm still testing this but getting ready to push this commit out.