Replace SHA-224 with SHA-256d

clifordsymack / Electron-Cash

Electrum; Bitcoin thin client

MIT License

6 stars 3 forks source link

Closed fyookball closed 5 years ago

fyookball commented 5 years ago

Please use a double round of sha-256, bitcoin style rather than SHA-224 when computing hash of the transaction.

this will prevent theoretical extention attacks and bring code more in line with bitcoin standards.

cculianu commented 5 years ago

You got it. So protocol version 300 it is! Third time's a charm (I hope)!

cculianu commented 5 years ago

See #104 . I'll merge this later today. Don't merge it yet.. i'm still testing other stuff. :)

cculianu commented 5 years ago

IT IS DONE.