clightning4j / JRPClightning

:zap: Java framework for C-Lightning to work with the RPC interface, and also the library simplifies the work to develop custom plugins with Java, Kotlin, and all the languages that supports the Java dependencies :zap:
https://clightning4j.github.io/JRPClightning/
GNU General Public License v2.0
16 stars 9 forks source link

Update APi in the readme #58

Closed vincenzopalazzo closed 3 years ago

vincenzopalazzo commented 3 years ago

I wrote the readme a lot of time ago, and I'm a very bad people to make this task.

I discovered that the API about the log level is old, we need to change it from

   @RPCMethod(
            name = "annotation_hello",
            description = "Annotation plugin"
    )
    public void hello(CLightningPlugin plugin, CLightningJsonObject request, CLightningJsonObject response) {
        log(CLightningLevelLog.WARNING, request.toString());
        response.add("type", "random");
    }

To

   @RPCMethod(
            name = "annotation_hello",
            description = "Annotation plugin"
    )
    public void hello(CLightningPlugin plugin, CLightningJsonObject request, CLightningJsonObject response) {
        log(PluginLog.WARNING, request.toString());
        response.add("type", "random");
    }
mhechavarria commented 3 years ago

Can I work on this, please?

vincenzopalazzo commented 3 years ago

@mhechavarria all yours

mhechavarria commented 3 years ago

Done, please review it: https://github.com/clightning4j/JRPClightning/pull/59