search

clightning4j / JRPClightning

:zap: Java framework for C-Lightning to work with the RPC interface, and also the library simplifies the work to develop custom plugins with Java, Kotlin, and all the languages that supports the Java dependencies :zap:
https://clightning4j.github.io/JRPClightning/
GNU General Public License v2.0
16 stars 9 forks source link

Use Github action matrix to check different version of Java #66

Closed Mrgove10 closed 2 years ago

Mrgove10 commented 2 years ago

V1 version for Fixes #23.

Unfortunately I get some Java error (I think it's linked to java / gradlew). Not being an expert, I am not sure how to fix it. I think the check file format step is failing for some reason.

codecov-commenter commented 2 years ago

Codecov Report

Merging #66 (62bc381) into master (cb772f8) will not change coverage. The diff coverage is 60.00%.

:exclamation: Current head 62bc381 differs from pull request most recent head afc13ea. Consider uploading reports for the commit afc13ea to get more accurate results Impacted file tree graph

@@            Coverage Diff            @@
##             master      #66   +/-   ##
=========================================
  Coverage     41.70%   41.70%           
  Complexity      334      334           
=========================================
  Files           128      128           
  Lines          2129     2129           
  Branches        149      149           
=========================================
  Hits            888      888           
  Misses         1151     1151           
  Partials         90       90
Flag Coverage Δ
unittests 41.70% <60.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../java/jrpc/service/socket/UnixDomainSocketRpc.java 50.66% <53.84%> (ø)
src/main/java/jrpc/clightning/CLightningRPC.java 61.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb772f8...afc13ea. Read the comment docs.

Mrgove10 commented 2 years ago

I think i have fixed the verrification issue but the build still doesn't pass image

Mrgove10 commented 2 years ago

I have made the changes but I still can not get it to build :(

vincenzopalazzo commented 2 years ago

I have made the changes but I still can not get it to build :(

Well, it is not "still" failing with the same error, this is a new one, and it is related to the jdk16. You can remove also this version, and I will fix this later https://github.com/clightning4j/JRPClightning/issues/67