search

clightning4j / JRPClightning

:zap: Java framework for C-Lightning to work with the RPC interface, and also the library simplifies the work to develop custom plugins with Java, Kotlin, and all the languages that supports the Java dependencies :zap:
https://clightning4j.github.io/JRPClightning/
GNU General Public License v2.0
16 stars 9 forks source link

fix(channel): `feerange` param in close command #78

Closed theborakompanioni closed 1 year ago

theborakompanioni commented 1 year ago

Currently evaluating if this library can be used as default client for cln nodes in https://github.com/theborakompanioni/bitcoin-spring-boot-starter .

Still testing and evaluating, but noticed that according to https://lightning.readthedocs.io/lightning-close.7.html, a param in the channel close command is called feerange, not feeange. I have not yet done any integration tests, so please excuse me if I am mistaken.

vincenzopalazzo commented 1 year ago

You are right, I did not maintain the java model because is more easy lever this to the user.

In fact, I start a lite client https://github.com/clightning4j/JRPClightning/blob/master/src/main/java/jrpc/clightning/LiteCLightningRPC.java maybe this helps you?

The usage of it should be pretty easy

  @Test
  public void testGetInfoCall() {
    CLightningGetInfo getInfo = liteRpc.call("getinfo", CLightningGetInfo.class);
    TestCase.assertFalse(getInfo.getId().isEmpty());
  }

Let me know if I can help with some things. The library should be using is running my lightning node with the plugin https://github.com/clightning4j/btcli4j it needs just some more love from time to time

Thanks for the patch!

vincenzopalazzo commented 1 year ago

now it should be available as a snapshot jar, so let wait that you play a little bit with it before push another official release