search

clightning4j / JRPClightning

:zap: Java framework for C-Lightning to work with the RPC interface, and also the library simplifies the work to develop custom plugins with Java, Kotlin, and all the languages that supports the Java dependencies :zap:
https://clightning4j.github.io/JRPClightning/
GNU General Public License v2.0
16 stars 9 forks source link

build(deps): expose gson dependency transitively #80

Closed theborakompanioni closed 1 year ago

theborakompanioni commented 1 year ago

Since gson is part of the API (e.g. in jrpc.service.converters.jsonwrapper.CLightningJsonObject#getAsJsonObject) it should be transitively exposed to all downstream consumers. Otherwise such libs would all have to define a dependency to gson manually.

Small cleanup included, e.g. check for null values at first possible chance, final fields, etc.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 63.63% and project coverage change: +0.03 :tada:

Comparison is base (53b8ec1) 41.52% compared to head (81387a5) 41.56%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #80 +/- ## ============================================ + Coverage 41.52% 41.56% +0.03% Complexity 332 332 ============================================ Files 128 128 Lines 2129 2127 -2 Branches 149 149 ============================================ Hits 884 884 + Misses 1154 1152 -2 Partials 91 91 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `41.56% <63.63%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=clightning4j#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/clightning4j/JRPClightning/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=clightning4j) | Coverage Δ | | |---|---|---| | [...e/converters/jsonwrapper/CLightningJsonObject.java](https://codecov.io/gh/clightning4j/JRPClightning/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=clightning4j#diff-c3JjL21haW4vamF2YS9qcnBjL3NlcnZpY2UvY29udmVydGVycy9qc29ud3JhcHBlci9DTGlnaHRuaW5nSnNvbk9iamVjdC5qYXZh) | `0.00% <0.00%> (ø)` | | | [...in/java/jrpc/service/converters/JsonConverter.java](https://codecov.io/gh/clightning4j/JRPClightning/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=clightning4j#diff-c3JjL21haW4vamF2YS9qcnBjL3NlcnZpY2UvY29udmVydGVycy9Kc29uQ29udmVydGVyLmphdmE=) | `68.75% <100.00%> (ø)` | | | [...ters/jsontypeadapter/BitcoinOutputTypeAdapter.java](https://codecov.io/gh/clightning4j/JRPClightning/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=clightning4j#diff-c3JjL21haW4vamF2YS9qcnBjL3NlcnZpY2UvY29udmVydGVycy9qc29udHlwZWFkYXB0ZXIvQml0Y29pbk91dHB1dFR5cGVBZGFwdGVyLmphdmE=) | `88.88% <100.00%> (ø)` | | | [...erters/jsontypeadapter/BitcoinUTXOTypeAdapter.java](https://codecov.io/gh/clightning4j/JRPClightning/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=clightning4j#diff-c3JjL21haW4vamF2YS9qcnBjL3NlcnZpY2UvY29udmVydGVycy9qc29udHlwZWFkYXB0ZXIvQml0Y29pblVUWE9UeXBlQWRhcHRlci5qYXZh) | `33.33% <100.00%> (ø)` | | | [...converters/jsontypeadapter/FeeRateTypeAdapter.java](https://codecov.io/gh/clightning4j/JRPClightning/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=clightning4j#diff-c3JjL21haW4vamF2YS9qcnBjL3NlcnZpY2UvY29udmVydGVycy9qc29udHlwZWFkYXB0ZXIvRmVlUmF0ZVR5cGVBZGFwdGVyLmphdmE=) | `66.66% <100.00%> (ø)` | | | [...verters/jsontypeadapter/InitMethodTypeAdapter.java](https://codecov.io/gh/clightning4j/JRPClightning/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=clightning4j#diff-c3JjL21haW4vamF2YS9qcnBjL3NlcnZpY2UvY29udmVydGVycy9qc29udHlwZWFkYXB0ZXIvSW5pdE1ldGhvZFR5cGVBZGFwdGVyLmphdmE=) | `85.71% <100.00%> (ø)` | | | [...ers/jsontypeadapter/ManifestMethodTypeAdapter.java](https://codecov.io/gh/clightning4j/JRPClightning/pull/80?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=clightning4j#diff-c3JjL21haW4vamF2YS9qcnBjL3NlcnZpY2UvY29udmVydGVycy9qc29udHlwZWFkYXB0ZXIvTWFuaWZlc3RNZXRob2RUeXBlQWRhcHRlci5qYXZh) | `51.02% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=clightning4j). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=clightning4j)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.