search

clightning4j / JRPClightning

:zap: Java framework for C-Lightning to work with the RPC interface, and also the library simplifies the work to develop custom plugins with Java, Kotlin, and all the languages that supports the Java dependencies :zap:
https://clightning4j.github.io/JRPClightning/
GNU General Public License v2.0
16 stars 9 forks source link

fix: re-add scanning classpath from property java.class.path #84

Closed theborakompanioni closed 1 year ago

theborakompanioni commented 1 year ago

Fixes a regression introduced in #81. With this commit applied, the former scanning approach is restored. However, since additional paths are scanned, I'd still consider it a breaking change. (I don't think anyone would be affected by that so far.)

theborakompanioni commented 1 year ago

Hey @vincenzopalazzo, any chance this will get released and published to maven central anytime soon(ish)? Would love to get rid of the custom build for cln-spend-and-replace-plugin. Also, after that, I'd tackle some refactoring you mentioned in https://github.com/clightning4j/JRPClightning/pull/85#discussion_r1178997199. Let me know what you think :pray:

vincenzopalazzo commented 1 year ago

Hey @theborakompanioni Yeah if you are testing in the snapshot I think we may build a official release for this :)

I will do it tomorrow if for you is ok

theborakompanioni commented 1 year ago

I will do it tomorrow if for you is ok

Take your time. There is no real urgency involved.