search

clightning4j / btcli4j

It is a core lightning plugin to override Bitcoin backend plugin with esplora by Blockstream and give the possibility to make the running process with bitcoind in pruning mode more solid.
GNU General Public License v2.0
9 stars 7 forks source link

Avoid to import binary and use the SNAPSHOT dependencies #32

Closed vincenzopalazzo closed 3 years ago

vincenzopalazzo commented 3 years ago

as @jsarenik suggested on IRC (#c-lightning) the plugin use a developing version of the last jar and avoid to bring in the devlib the jar

jsarenik commented 3 years ago

@vincenzopalazzo amazing! Thank you! Didn't have to move a finger :)

vincenzopalazzo commented 3 years ago

@jsarenik :-D, i will suppose that you don't have a problem with the plugin, any crash to report? or we can move to mainet?

jsarenik commented 3 years ago

@vincenzopalazzo no crash, though I am not running 24/7, it was humming marrily for hours at least (unlike esplora_clnd_plugin plugin error reported in https://github.com/lightningamp/esplora_clnd_plugin/issues/47).

vincenzopalazzo commented 3 years ago

We will catch the error in the esplora_clnd_plugin too, this plugin can help to understand how it important have an error recovery.

Another thing, if you have a log file can you run this command cat path/logFile.log | grep retry for me and report the result?

jsarenik commented 3 years ago

@vincenzopalazzo do you mean log file of a lightningd running with btcli4j plugin?

vincenzopalazzo commented 3 years ago

@jsarenik yes exactly

jsarenik commented 3 years ago

@vincenzopalazzo No line containing retry in my logs so far.

vincenzopalazzo commented 3 years ago

@jsarenik no error at all, good news

By default now the plugin retries the request 4 time with an increase waiting time if you want know how many time the plugin was able to recover an error, you can use this command