search

clij / clij2-fft

20 stars 6 forks source link

Macos build #8

Closed haesleinhuepf closed 3 years ago

haesleinhuepf commented 3 years ago

Hey Brian @bnorthan ,

here cone my changes regarding the build on macos. Happy to straighten things if necessary.

Let me know what you think!

Cheers, Robert

haesleinhuepf commented 3 years ago

Hey Brian @bnorthan ,

I just adapted the path. Would you mind testing once again (if not done in the recent days) that deconvolution using the clij2-fft which is currently on the update site also works on your linux?

If so, we could merge this and cut a proper release.

Thanks for your support!

Cheers, Robert

bnorthan commented 3 years ago

I had to update the linux libraries to get it to work see this commit

After that I had to [tweak the test script](https://github.com/clij/clij2-fft/commit/5c11338405664bf7399f2c222484a40ad2693129]

I had to convert to 32 bit before calling the plugin, which doesn't quite make sense since it should be done inside. Is there a preprocessor or something that checks that the input and output match and will stop things if it doesn't?? I plan to investigate more tomorrow.

bnorthan commented 3 years ago

Hi @haesleinhuepf

I fixed the conversion bug so I think it is ready to merge.

Do you want to add the new linux libraries to the update site and have me test again just to make sure? Do we need to test via the updater on Windows as well?

haesleinhuepf commented 3 years ago

Hey Brian @bnorthan ,

Do we need to test via the updater on Windows as well?

I did that already on Intel/AMD/Nvidia GPUs for Windows. But feel free to test more. Four eyes see more than two ;-)

Do you want to add the new linux libraries to the update site and have me test again just to make sure?

I just built it on Linux (worked like a charm), but it results in images containing NaN only. I had some bad experience with my Intel GPU on linux. Hence I'm not sure if it's a GPU/driver problem or a code problem. Would you mind testing on your linux? You have an NVidia GPU in there, right? The updated native files for linux are on the update site and in this branch: https://github.com/clij/clij2-fft/tree/linux_build

Thanks!

Cheers, Robert

bnorthan commented 3 years ago

Hey - I got distracted on other things and neglected this. I just tested the linux libs that are on the update site, and they look to work fine.

haesleinhuepf commented 3 years ago

Hey Brian @bnorthan ,

no worries because of delay. Thanks for looking into this. I'll merge it now.

Thanks again for all your help. I owe you a beer at least ;-)

Cheers, Robert