climate-cooperative / home-energy-calculator

https://app.zwell.io/

Apache License 2.0

2 stars 3 forks source link

add padding below "Next button" #78

Closed sfishel18 closed 1 month ago

sfishel18 commented 1 month ago

76

sfishel18 commented 1 month ago

before:

after:

sfishel18 commented 1 month ago

@rgraue i got an email from github with a comment from you on this PR pointing out that it would be better not to use a static pixel value for this padding. for some reason i don't see that comment on the PR itself though.

but anyway, that's a good call, and i was going to follow up and ask if you prefer % vs rem vs vh for the dynamic version of the padding

rgraue commented 1 month ago

@rgraue i got an email from github with a comment from you on this PR pointing out that it would be better not to use a static pixel value for this padding. for some reason i don't see that comment on the PR itself though.

but anyway, that's a good call, and i was going to follow up and ask if you prefer % vs rem vs vh for the dynamic version of the padding

Weird... might be a setting for pr comments. I'll look around those and see I think % might be the best for what were looking for here... although im no style wizard, so maybe em might be good too, if we want it to inherit from whatever class its nested in

sfishel18 commented 1 month ago

@rgraue i got an email from github with a comment from you on this PR pointing out that it would be better not to use a static pixel value for this padding. for some reason i don't see that comment on the PR itself though. but anyway, that's a good call, and i was going to follow up and ask if you prefer % vs rem vs vh for the dynamic version of the padding

Weird... might be a setting for pr comments. I'll look around those and see I think % might be the best for what were looking for here... although im no style wizard, so maybe em might be good too, if we want it to inherit from whatever class its nested in

updated the PR to use %, seems to be working well to my eye