Data structure - [merged]

[lewisjared]

In GitLab by @yinilaii on Nov 29, 2023, 14:18

_Merges datastructure -> main

Pull request

Please confirm that this pull request has done the following:

• [ ] Tests added
• [ ] Documentation added (where applicable)
• [ ] Example added (either to an existing notebook or as a new notebook, where applicable)
• [x] Changelog entry added to /changelog
• [ ] Book has been published and verified with the CI (where applicable)

[lewisjared]

In GitLab by @yinilaii on Nov 29, 2023, 14:18

requested review from @yinilaii and @lewisjared

[lewisjared]

In GitLab by @yinilaii on Nov 29, 2023, 14:25

added 1 commit

• 85753af5 - add changelog

Compare with previous version

[lewisjared]

def print_dataset_structure(data: ScmRun) -> None:

[lewisjared]

The types aren't needed here as we use type-hints above

[lewisjared]

    for column in data.meta_attributes:

[lewisjared]

pytest should be a development dependency not a project dependency. The difference is that that project dependencies will be installed by end-users of this package -they don't need to run the tests so don't need the dependency

[lewisjared]

Can we add a line under the headers to visually distinguish them?

        "model      region          scenario     unit            variable        \n"
        "-----      ------          --------     ----            --------        \n"

[lewisjared]

Nice. A few minor tweaks and this will be ready

[lewisjared]

    data

[lewisjared]

[lewisjared]

remove line and then run poetry lock --no-update

[lewisjared]

In GitLab by @yinilaii on Dec 4, 2023, 11:10

Commented on src/bookshelf/dataset_structure.py line 41

changed this line in version 3 of the diff

[lewisjared]

In GitLab by @yinilaii on Dec 4, 2023, 11:10

Commented on src/bookshelf/dataset_structure.py line 29

changed this line in version 3 of the diff

[lewisjared]

In GitLab by @yinilaii on Dec 4, 2023, 11:10

Commented on src/bookshelf/dataset_structure.py line 34

changed this line in version 3 of the diff

[lewisjared]

In GitLab by @yinilaii on Dec 4, 2023, 11:10

Commented on pyproject.toml line 39

changed this line in version 3 of the diff

[lewisjared]

In GitLab by @yinilaii on Dec 4, 2023, 11:10

Commented on src/bookshelf/dataset_structure.py line 24

changed this line in version 3 of the diff

[lewisjared]

In GitLab by @yinilaii on Dec 4, 2023, 11:10

added 1 commit

• 6849d0fd - add header divider ect.

Compare with previous version

[lewisjared]

In GitLab by @yinilaii on Dec 4, 2023, 11:12

resolved all threads

[lewisjared]

marked the checklist item Changelog entry added to /changelog as completed

[lewisjared]

def get_dataset_dictionary(data: ScmRun) -> dict[str, str|float|int]:

[lewisjared]

One last change and then I'll merge

[lewisjared]

approved this merge request

[lewisjared]

In GitLab by @yinilaii on Dec 4, 2023, 12:59

Commented on src/bookshelf/dataset_structure.py line 14

changed this line in version 4 of the diff

[lewisjared]

In GitLab by @yinilaii on Dec 4, 2023, 12:59

added 1 commit

• 72200506 - revise function output type

Compare with previous version

[lewisjared]

In GitLab by @yinilaii on Dec 4, 2023, 12:59

resolved all threads

[lewisjared]

Can you remove these?

[lewisjared]

from __future__ import annotations

[lewisjared]

approved this merge request

[lewisjared]

In GitLab by @yinilaii on Dec 4, 2023, 13:55

Commented on src/bookshelf/dataset_structure.py line 39

changed this line in version 5 of the diff

[lewisjared]

In GitLab by @yinilaii on Dec 4, 2023, 13:55

Commented on src/bookshelf/dataset_structure.py line 9

changed this line in version 5 of the diff

[lewisjared]

In GitLab by @yinilaii on Dec 4, 2023, 13:55

added 1 commit

• d2b3709d - remove %%

Compare with previous version

[lewisjared]

added 1 commit

• 8e086b1e - chore: Fix type hints

Compare with previous version

[lewisjared]

approved this merge request

[lewisjared]

mentioned in commit 2173b0063267e13789efcdd93d725231ce773f55

[lewisjared]

unassigned @yinilaii